Merge pull request #229 from synonymdev/channel-id-fix

fix: correct channel id in listing channel monitors
synonymdev · Mar 27, 2024 · ffb7cfa · ffb7cfa
2 parents 067f7b6 + 59a80e5
commit ffb7cfa
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 6 deletions.
diff --git a/lib/android/src/main/java/com/reactnativeldk/Helpers.kt b/lib/android/src/main/java/com/reactnativeldk/Helpers.kt
@@ -203,7 +203,8 @@ val RouteHop.asJson: WritableMap
 fun ChannelMonitor.asJson(channelId: String): WritableMap {
     val result = Arguments.createMap()
     result.putString("channel_id", channelId)
-    result.putHexString("funding_txo", _funding_txo._b)
+    result.putInt("funding_txo_index", _funding_txo._a._index.toInt())
+    result.putHexString("funding_txo_txid", _funding_txo._a.to_channel_id().reversedArray())
     result.putHexString("counterparty_node_id", _counterparty_node_id)
 
     val balances = Arguments.createArray()

diff --git a/lib/android/src/main/java/com/reactnativeldk/LdkModule.kt b/lib/android/src/main/java/com/reactnativeldk/LdkModule.kt
@@ -967,7 +967,7 @@ class LdkModule(reactContext: ReactApplicationContext) : ReactContextBaseJavaMod
 
             if (channelMonitor.is_ok) {
                 val channelMonitorResult = (channelMonitor as Result_C2Tuple_ThirtyTwoBytesChannelMonitorZDecodeErrorZ_OK)
-                result.pushMap(channelMonitorResult.res._b.asJson(channelMonitorResult.res._a.hexEncodedString()))
+                result.pushMap(channelMonitorResult.res._b.asJson(channelId))
             }
         }
 

diff --git a/lib/ios/Helpers.swift b/lib/ios/Helpers.swift
@@ -191,7 +191,8 @@ extension ChannelMonitor {
     func asJson(channelId: String) -> [String: Any?] {
         return [
             "channel_id": channelId,
-            "funding_txo": Data(getFundingTxo().1).hexEncodedString(),
+            "funding_txo_index": getFundingTxo().0.getIndex(),
+            "funding_txo_txid": Data(getFundingTxo().0.getTxid()?.reversed() ?? []).hexEncodedString(),
             "counterparty_node_id": Data(getCounterpartyNodeId() ?? []).hexEncodedString(),
             "claimable_balances": getClaimableBalances().map({ $0.asJson })
         ]

diff --git a/lib/ios/Ldk.swift b/lib/ios/Ldk.swift
@@ -1040,12 +1040,12 @@ class Ldk: NSObject {
                 argB: keysManager.signerProvider
             )
 
-            guard let (channelId, channelMonitor) = channelMonitorResult.getValue() else {
+            guard let (_, channelMonitor) = channelMonitorResult.getValue() else {
                 LdkEventEmitter.shared.send(withEvent: .native_log, body: "Loading channel error. No channel value.")
                 continue
             }
 
-            result.append(channelMonitor.asJson(channelId: Data(channelId).hexEncodedString()))
+            result.append(channelMonitor.asJson(channelId: channelId))
         }
 
         return resolve(result)

diff --git a/lib/src/utils/types.ts b/lib/src/utils/types.ts
@@ -166,7 +166,8 @@ export type TChannel = {
 
 export type TChannelMonitor = {
 	channel_id: string;
-	funding_txo: string;
+	funding_txo_index: number;
+	funding_txo_txid: string;
 	counterparty_node_id: string;
 	claimable_balances: [TClaimableBalance];
 };