Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(wallet): Increase Gap Limit #1954

Merged
merged 1 commit into from
Jun 5, 2024
Merged

chore(wallet): Increase Gap Limit #1954

merged 1 commit into from
Jun 5, 2024

Conversation

coreyphillips
Copy link
Collaborator

Description

  • Increases default gap limit to 10 for new wallets.
  • Removes unused constants.

Type of change

  • Refactoring (improving code without creating new functionality)

Tests

  • No test

QA Notes

  • New wallets should now have a default gap limit of 10 that can be confirmed by navigating to "Settings->Advanced->Address Gap Limit".

@coreyphillips
chore(wallet): Increase Gap Limit
77ceb05 
Increases default gap limit to 10 for new wallets.
Removes unused constants.
@coreyphillips coreyphillips requested a review from limpbrains June 5, 2024 14:14
@coreyphillips coreyphillips merged commit 0cb5aaf into master Jun 5, 2024
6 checks passed
@coreyphillips coreyphillips deleted the increase-gap-limit branch June 5, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limpbrains limpbrains limpbrains approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coreyphillips @limpbrains