Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transfer): respect node capacity limit in custom setup #1946

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Jun 4, 2024

Description

  • Include existing channels when calculating client and lsp balances for the custom setup.
  • ChannelList buttons navigate to custom setup (as per design)

Linked Issues/Tasks

Closes #1563

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

Simulator.Screen.Recording.-.iPhone.15.-.2024-06-04.at.17.58.54.mp4

QA Notes

Custom Setup should not let you open a channel that puts you over the LSP node capacity limit (preventing the channel from being opened)

@pwltr pwltr requested a review from coreyphillips June 4, 2024 18:01
@pwltr pwltr merged commit 7a16b89 into master Jun 5, 2024
6 checks passed
@pwltr pwltr deleted the fix/custom-setup branch June 5, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Prevent user from buying channel when node capacity is reached
2 participants