Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet): Add optional chaining to selectedAddress in AddressViewer #1590

Merged
merged 1 commit into from
Feb 27, 2024
Merged

fix(wallet): Add optional chaining to selectedAddress in AddressViewer #1590

merged 1 commit into from
Feb 27, 2024

Conversation

coreyphillips
Copy link
Collaborator

Description

  • Prevents the following from occurring when the addresses on the AddressViewer take longer to load on some devices.
    • Error: Cannot read property 'address' of undefined Component Stack: in AddressViewer

Linked Issues/Tasks

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Tests

  • No test

QA Notes

  • Navigating to the AddressViewer component in Settings->Advanced->Address Viewer should not crash the app and load the addresses as expected.

@coreyphillips coreyphillips merged commit e2d233f into master Feb 27, 2024
4 checks passed
@coreyphillips coreyphillips deleted the fix/address-viewer branch February 27, 2024 11:00
@JeanlChristophe
Copy link

please don't forget to add to each ticket:

  • Project
  • Status
  • Sprint
  • Milestone
    Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limpbrains limpbrains limpbrains approved these changes

Assignees

@coreyphillips coreyphillips

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coreyphillips @JeanlChristophe @limpbrains