Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: get selected wallet and network by default #1567

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

ovitrif
Copy link
Contributor

@ovitrif ovitrif commented Feb 16, 2024

Description

Refactors the code to replace occurrences of

if (!selectedNetwork) {
  selectedNetwork = getSelectedNetwork();
}

and / or :

if (!selectedWallet) {
  selectedWallet = getSelectedWallet();
}

with default parameter values, ie.

selectedWallet = getSelectedWallet(),
selectedNetwork = getSelectedNetwork(),

Type of change

  • Refactoring (improving code without creating new functionality)

Tests

  • No test

src/utils/wallet/transactions.ts Outdated Show resolved Hide resolved
src/utils/wallet/transactions.ts Outdated Show resolved Hide resolved
@ovitrif ovitrif force-pushed the refactor/selected-wallet-and-network branch from 724ec1d to a9c55f7 Compare February 16, 2024 15:15
@ovitrif
Copy link
Contributor Author

ovitrif commented Feb 16, 2024

@limpbrains e2e-ios fails here, should I be concerned? the one on macmini succeeds 🤔

It seems unrelated to the changes (IMHO), though I wonder what might cause the failure

From build logs these seemed to stand out:

[!] Error installing hermes-engine

and

Errno::EEXIST - File exists @ syserr_fail2_in - /Users/runner/Library/Caches/CocoaPods/Pods/External/hermes-engine/297ebba3ddadb20a86a625cc0bfe59ba-9180d/destroot/Library/Frameworks/universal/hermes.xcframework/ios-arm64_x86_64-maccatalyst/hermes.framework/Resources

@limpbrains
Copy link
Collaborator

Yes, it is unrelated. Broken cocoapods version

@coreyphillips coreyphillips merged commit c52543d into master Feb 16, 2024
4 of 5 checks passed
@coreyphillips coreyphillips deleted the refactor/selected-wallet-and-network branch February 16, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants