feat(lightning): Add Custom RGS Server #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds ability for users to add custom RGS servers in Advanced Settings.
pwltr
approved these changes
Oct 19, 2023
Jasonvdb
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
We should maybe indicate a restart is required to take affect. Also when switching servers incremental syncs won't work so on first startup it'll error and return empty graph but on next startup sync from scratch. So maybe best to stop ldk, delete current graph cache and then restart.
Added toast notification to inform the user they may need to updated their app.
|
Added a notification to alert the user that they may need to update the app once or twice to apply the change. It will currently stop the node and restart LDK with the new RGS info, but I don't believe we have exposed a method to delete the net graph info just yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Tests
Screenshot / Video