-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rewrite todo cards logic #1291
Conversation
8c1ac36
to
4a24ba7
Compare
Nice, way cleaner than before. Just a couple of findings:
|
Lets keep it for now. It is still nice to have this confirmatioln when you channel is finally open, even if you already have one
fixed
fixed
will fix in #398 someday :) |
Fine with me but maybe check with Aldert as this is not how it is in the design.
This issue is still there: Simulator.Screen.Recording.-.iPhone.14.-.2023-10-09.at.14.36.20.mp4 |
92add1c
to
6cb751b
Compare
I don't think this is an issue, you have already setup lightning. "Fixing" this requires more complexity. |
Description
To fix and simplify Todo cards logic I refactored it's logic. Now cards list derived from state, rathen than be stored in redux state. No more
addTodo
andremoveTodo
actions.For example:
All cards logic is now in
todosFullSelector
and there are tests for it.Also I've replaced lodash/* libs with one.
Linked Issues/Tasks
closes #1162
Type of change
Refactoring
Tests
Unit test