Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add wallet stop method #86

Merged
merged 1 commit into from
Nov 29, 2024
Merged

feat: add wallet stop method #86

merged 1 commit into from
Nov 29, 2024

Conversation

limpbrains
Copy link
Collaborator

Depends on #85

Adds the wallet.stop() method that should be used to prepare the wallet to be destroyed / replaced

  • stops electrum
  • replaces setData with undefined to prevent wallet saving any data
  • sets disableMessages to false so that wallet does not emmit any messages using onMessage callback

tests included

@limpbrains limpbrains marked this pull request as ready for review November 29, 2024 11:20
@limpbrains limpbrains merged commit 0f6cea1 into master Nov 29, 2024
3 checks passed
@limpbrains limpbrains deleted the stop branch November 29, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwltr pwltr pwltr approved these changes

@coreyphillips coreyphillips Awaiting requested review from coreyphillips

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@limpbrains @pwltr