feat: don't generate A instructions #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flouse
approved these changes
Dec 11, 2023
yangby-cryptape
approved these changes
Dec 11, 2023
ashuralyk
approved these changes
Dec 12, 2023
blckngm
force-pushed
the
write-commitment
branch
2 times, most recently
from
6c8dd0c to
0ba0754
Compare
blckngm
force-pushed
the
write-commitment
branch
from
0ba0754 to
4d96f0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A instructions are only supported after ckb 2023 hardfork. It's not supported on ckb testnet or mainnet now.
So we use some compiler and linking hacks to avoid generating A instructions. See https://github.com/xxuejie/ckb-contract-bytes-without-a/ for a more detailed explanation.