chore: more clippy lints

Cargo.toml

@@ -40,6 +40,23 @@ nightly = []
 # for tests only
 as-root = []
 
+[lints.rust]
+missing_docs = "warn"
+unsafe_code = "forbid"
+
+[lints.clippy]
+clone_on_ref_ptr = "warn"
+dbg_macro = "warn"
+format_push_string = "warn"
+if_then_some_else_none = "warn"
+multiple_inherent_impl = "warn"
+ref_patterns = "warn"
+semicolon_inside_block = "warn"
+str_to_string = "warn"
+string_to_string = "warn"
+unneeded_field_pattern = "warn"
+verbose_file_reads = "warn"
+
 [package.metadata.deb]
 name = "shh"
 depends = "$auto, strace"

src/cl.rs

@@ -4,6 +4,7 @@ use std::path::PathBuf;
 
 use clap::Parser;
 
+/// Command line arguments
 #[derive(Parser, Debug)]
 pub struct Args {
     #[command(subcommand)]

src/main.rs

@@ -1,3 +1,5 @@
+//! Systemd Hardening Helper
+
 #![cfg_attr(all(feature = "nightly", test), feature(test))]
 
 use std::{
@@ -42,7 +44,7 @@ fn main() -> anyhow::Result<()> {
     let strace_version = strace::StraceVersion::local_system()?;
     log::info!("Detected versions: Systemd {sd_version}, Linux kernel {kernel_version}, strace {strace_version}");
     if strace_version < strace::StraceVersion::new(6, 4) {
-        log::warn!("Strace version >=6.4 is strongly recommended, if you experience strace output parsing errors, please consider upgrading")
+        log::warn!("Strace version >=6.4 is strongly recommended, if you experience strace output parsing errors, please consider upgrading");
     }
 
     // Parse cl args
@@ -145,7 +147,7 @@ fn main() -> anyhow::Result<()> {
                 "Resolved systemd options: {}",
                 resolved_opts
                     .iter()
-                    .map(|o| format!("{}", o))
+                    .map(|o| format!("{o}"))
                     .collect::<Vec<_>>()
                     .join(", ")
             );