-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds dark theme and theme switching functionality (REPL + website) #25
base: main
Are you sure you want to change the base?
Conversation
This looks great, thanks @agriyakhetarpal!
For reference there is now an extension to provide that kind of bridge between a host page and a JupyterLab / JupyterLite instance running in the IFrame: https://github.com/TileDB-Inc/jupyter-iframe-commands. So it could be interesting to try to use that extension here, and see if it helps simplify the diff and not have to add a new extension. That would mean:
|
Description
This PR adds a dark theme to the overall website. The REPL iframe can switch themes without having to restart the kernel, which requires a theme bridge as described in https://jupyterlite.readthedocs.io/en/stable/howto/configure/advanced/iframe.html
Tip
This PR is a work-in-progress and is not yet ready for review. However, initial feedback is welcome. The description below is a stub.
An initial look is looking good, so far:
Screen.Recording.2025-01-16.at.2.43.37.AM.mov
Closes sympy/sympy.github.com#199
TODO items
prefers-color-scheme
patch