Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LiveComponent] remove form property in live component docs #2474

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

jannes-io
Copy link
Contributor

Q A
Bug fix? no
New feature? no
Issues
License MIT

Passing the form as a property isn't explained until the next section down in the docs. This clears up the example to make it less confusing.

Passing the form as a property isn't explained until the next section down in the docs. This clears up the example example to make it less confusing.
@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Dec 30, 2024
@jannes-io jannes-io changed the title remove form property in live component docs [LiveComponent] remove form property in live component docs Dec 30, 2024
Copy link
Member

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted!

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Jan 1, 2025
@Kocal
Copy link
Member

Kocal commented Jan 5, 2025

Thank you @jannes-io.

@Kocal Kocal merged commit 2ca3f33 into symfony:2.x Jan 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants