-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Turbo] Add generic <Turbo:Stream>
component
#2302
Conversation
<Turbo:Stream>
component<Turbo:Stream>
component
<Turbo:Stream>
component<Turbo:Stream>
component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the CHANGELOG here please? Thanks
Is there any advantage here (apart from the syntax) ? Because <turbo-frame foo bar>foo bar</turbo-frame> and <twig:Turbo:Frame foo bar>
foo bar
</twig:Turbo:Frame> have a real difference in term of performance. But i get the target to cover all bases of turbo with one syntax. Thinking outloud here.. not sure what to do. I wonder if we should not make a search/replace here, instead of calling an embedding component 🤷 |
Done |
This comment is rather related to this PR I think no?: #2303 |
Thank you @seb-jean. |
I added a generic Turbo Stream component. To use it, you can do this:
The rendering is: