Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Turbo] delete whitespace for <twig:Turbo:Stream:*> components #2300

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

seb-jean
Copy link
Contributor

@seb-jean seb-jean commented Oct 25, 2024

Q A
Bug fix? yes
New feature? no

I added whitespace trimming for delete a whitespace for <twig:Turbo:Stream:*> components.

Example with below code:

<twig:Turbo:Stream:Append target="#count-post">
    <div>12</div>
</twig:Turbo:Stream:Append>

Before

<turbo-stream action="append" targets="#count-post" >
<template><div>12</div>
</template>
</turbo-stream>

After

<turbo-stream action="append" targets="#count-post">
<template><div>12</div>
</template>
</turbo-stream>

@carsonbot carsonbot added Bug Bug Fix Turbo Status: Needs Review Needs to be reviewed labels Oct 25, 2024
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Oct 25, 2024
@Kocal
Copy link
Member

Kocal commented Oct 25, 2024

Thank you @seb-jean.

@Kocal Kocal merged commit 01839ab into symfony:2.x Oct 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug Fix Status: Reviewed Has been reviewed by a maintainer Turbo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants