-
-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LiveComponent] Fix PHP8.4 errors + deprecations #2079
Conversation
🆘 @kbond 😅 |
Oi! We don't run foundry's CI on PHP 8.4 yet - hopefully these are issues there. I've created an issue to track zenstruck/foundry#687 |
@kbond sorry i was unclear 😓 I started on PHP 8.4 but there were deprecations on PHP 8.3.. So i decided to un-lock the Foundry version. This PR failures come from me upgrading Foundry, but are on the current PHP version... and i'm a bit blocked here :/ i must have messed something in the upgrade |
Hi @smnandre I've opened a PR based on yours which fixes the CI I'm not really sure where the problem was coming from, though 😅 |
Oh this is no nice, thank you !! 😃 |
I'll merge it in mine and we'll see from there.. as the CI does not run on my fork :) |
3efde01
to
e56bdbe
Compare
Looks good.... (thank you very much!)) .. I'm sorry 😅 |
Update: not at all, 100% my fault ....
Lucide is just no the only result for the query "lucide" ... deepest apologies 💐 |
Oi, yeah that's a brittle test |
3fd1445
to
0a862d7
Compare
First patch of fixes (thanks to the PHP 8.4 tesst)