Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Translator] Revert #1965, which break cache warmup for Symfony applications #2060

Merged
merged 1 commit into from
Aug 14, 2024
+0 −56
Merged

[Translator] Revert #1965, which break cache warmup for Symfony applications #2060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/Translator/doc/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,6 @@ For a better developer experience, TypeScript types definitions are also generat
Then, you will be able to import those JavaScript translations in your assets.
Don't worry about your final bundle size, only the translations you use will be included in your final bundle, thanks to the `tree shaking <https://webpack.js.org/guides/tree-shaking/>`_.

.. note::

This package requires the `translator` to be enabled in your Symfony application. If you don't use the `translator` service, the warmup command will not generate any translations.

Configuring the dumped translations
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Expand Down
40 changes: 0 additions & 40 deletions src/Translator/src/DependencyInjection/TranslatorCompilerPass.php
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions src/Translator/src/UxTranslatorBundle.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@

namespace Symfony\UX\Translator;

use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\HttpKernel\Bundle\Bundle;
use Symfony\UX\Translator\DependencyInjection\TranslatorCompilerPass;

/**
* @author Hugo Alliaume <[email protected]>
Expand All @@ -28,9 +26,4 @@ public function getPath(): string
{
return \dirname(__DIR__);
}

public function build(ContainerBuilder $container): void
{
$container->addCompilerPass(new TranslatorCompilerPass());
}
}
4 changes: 0 additions & 4 deletions src/Translator/tests/Kernel/FrameworkAppKernel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@ public function registerContainerConfiguration(LoaderInterface $loader)
'secret' => '$ecret',
'test' => true,
'translator' => [
'enabled' => match ($this->environment) {
'test_without_translator' => false,
default => true,
},
'fallbacks' => ['en'],
],
'http_method_override' => false,
Expand Down
1 change: 0 additions & 1 deletion src/Translator/tests/UxTranslatorBundleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public static function provideKernels()
{
yield 'empty' => [new EmptyAppKernel('test', true)];
yield 'framework' => [new FrameworkAppKernel('test', true)];
yield 'framework without translator' => [new FrameworkAppKernel('test_without_translator', true)];
}

/**
Expand Down