Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TwigComponent][WebProfiler] Add profile + StopWatch + WDT #1152

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Sep 29, 2023

Add a DataCollector to add data in the web debug toolpar and a profiler pane.

Based on the events (PreRender / PostRender) triggerd during the request.

Overview Details
overview details
Anonymous components Stopwatch + performance
anonymous-timing perforlmance

@smnandre smnandre force-pushed the feat/twig-component-profiler branch from a20e459 to 09fd784 Compare September 29, 2023 22:46
@smnandre smnandre changed the title [TwigComponent] Add profiler integration (StopWatch / profiler / [TwigComponent][WebProfiler] Add profile + StopWatch + WDT Sep 29, 2023
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is QUITE impressive 👏. I've left some minor notes, but I think we should get this in. I'm sure we will think of other info that will be useful, but wow - was this fun to play with!

@smnandre smnandre force-pushed the feat/twig-component-profiler branch 2 times, most recently from 50fadb2 to 13429e6 Compare October 3, 2023 15:25
@weaverryan weaverryan force-pushed the feat/twig-component-profiler branch from 13429e6 to 28baab1 Compare October 3, 2023 15:40
@weaverryan
Copy link
Member

Thank you for this fantastic PR Simon!

@weaverryan weaverryan merged commit d244c0c into symfony:2.x Oct 3, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants