bug #2060 [Translator] Revert #1965, which break cache warmup for Sym…

…fony applications (Kocal)

This PR was merged into the 2.x branch.

Discussion
----------

[Translator] Revert #1965, which break cache warmup for Symfony applications

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Issues        | Fix #2056 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT

<!--
Replace this notice by a description of your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - For new features, provide some code snippets to help understand usage.
 - Features and deprecations must be submitted against branch main.
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility (see https://symfony.com/bc).
-->

Hi everyone!

It looks like we were too fast on #1965, and our tests base didn't see the issue.

With 2.19.0, people started to have issues with the CacheWarmer from UX Translator, which was... simply never called, and so the folder `var/translations` was not generated anymore.

In private, we've decided to revert the feature to fix the issue, and to re-open the discussion if necessary.

Commits
-------

baf9f5e [Translator] Revert #1965, which break cache warmup for Symfony applications

src/Translator/doc/index.rst

@@ -71,10 +71,6 @@ For a better developer experience, TypeScript types definitions are also generat
 Then, you will be able to import those JavaScript translations in your assets.
 Don't worry about your final bundle size, only the translations you use will be included in your final bundle, thanks to the `tree shaking <https://webpack.js.org/guides/tree-shaking/>`_.
 
-.. note::
-
-    This package requires the `translator` to be enabled in your Symfony application. If you don't use the `translator` service, the warmup command will not generate any translations.
-
 Configuring the dumped translations
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 

src/Translator/src/UxTranslatorBundle.php

@@ -11,9 +11,7 @@
 
 namespace Symfony\UX\Translator;
 
-use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\HttpKernel\Bundle\Bundle;
-use Symfony\UX\Translator\DependencyInjection\TranslatorCompilerPass;
 
 /**
  * @author Hugo Alliaume <[email protected]>
@@ -28,9 +26,4 @@ public function getPath(): string
     {
         return \dirname(__DIR__);
     }
-
-    public function build(ContainerBuilder $container): void
-    {
-        $container->addCompilerPass(new TranslatorCompilerPass());
-    }
 }

src/Translator/tests/Kernel/FrameworkAppKernel.php

@@ -38,10 +38,6 @@ public function registerContainerConfiguration(LoaderInterface $loader)
                 'secret' => '$ecret',
                 'test' => true,
                 'translator' => [
-                    'enabled' => match ($this->environment) {
-                        'test_without_translator' => false,
-                        default => true,
-                    },
                     'fallbacks' => ['en'],
                 ],
                 'http_method_override' => false,

src/Translator/tests/UxTranslatorBundleTest.php

@@ -22,7 +22,6 @@ public static function provideKernels()
     {
         yield 'empty' => [new EmptyAppKernel('test', true)];
         yield 'framework' => [new FrameworkAppKernel('test', true)];
-        yield 'framework without translator' => [new FrameworkAppKernel('test_without_translator', true)];
     }
 
     /**