Merge branch '3.4' into 4.4

* 3.4: [HttpFoundation] Skip the cookie_max_age fixture on PHP 8. add choice_translation_domain tests to prevent further regressions Update validators.tr.xlf
symfony · Sep 13, 2020 · ff509ca · ff509ca
2 parents e52961a + 2264e38
commit ff509ca
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/Tests/ResponseFunctionalTest.php b/Tests/ResponseFunctionalTest.php
@@ -42,6 +42,10 @@ public static function tearDownAfterClass(): void
      */
     public function testCookie($fixture)
     {
+        if (\PHP_VERSION_ID >= 80000 && 'cookie_max_age' === $fixture) {
+            $this->markTestSkipped('This fixture produces a fatal error on PHP 8.');
+        }
+
         $result = file_get_contents(sprintf('http://localhost:8054/%s.php', $fixture));
         $this->assertStringMatchesFormatFile(__DIR__.sprintf('/Fixtures/response-functional/%s.expected', $fixture), $result);
     }