fix: improved message api #818
Conversation
fboucquez
force-pushed
the
message_improvements
branch
from
68177a2 to
191f4d0
Compare
fboucquez
force-pushed
the
message_improvements
branch
2 times, most recently
from
b61d875 to
632f299
Compare
fix: Improved Crypto unit testing fix: Moved "decode" to Convert.hexToUtf8 fix: EncryptedMessage payload wasn't reproducible.
fboucquez
force-pushed
the
message_improvements
branch
from
632f299 to
1bbee2b
Compare
| @@ -0,0 +1,38 @@ | |||
| /* | |||
| * Copyright 2018 NEM | |||
There was a problem hiding this comment.
This should be (C) Symbol Contributors 2021.
There was a problem hiding this comment.
I'll update this one, but we would need to update licensing in all the files.
There was a problem hiding this comment.
/*
* (C) Symbol Contributors 2021
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
Is this the new correct licensing? We would need to patch all the files in another pr.
src/core/crypto/Crypto.ts
Outdated
| @@ -171,7 +177,7 @@ export class Crypto { | |||
| try { | |||
| const decoded = Crypto._decode(recipientPrivate, senderPublic, payloadBuffer, tagAndIv); | |||
| return decoded.toUpperCase(); | |||
| } catch { | |||
| } catch (e) { | |||
| // To return empty string rather than error throwing if authentication failed | |||
There was a problem hiding this comment.
What was the reasoning behind returning an empty string rather than an error?
There was a problem hiding this comment.
You are right, we should probably raise an Error. This is a behaviour change, we could do it now too
There was a problem hiding this comment.
Updated to raise an error. Note that clients would need to catch them if they aren't decrypting correctly.
Throwing error when payload cannot be decrypted.
fboucquez
force-pushed
the
message_improvements
branch
from
6aa0a5e to
1317bed
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
fix: Improved Crypto unit testing
fix: Moved "decode" to Convert.hexToUtf8
fix: EncryptedMessage payload wasn't reproducible.
This fix allows devs to pull the transfer's message bytes as-is without any conventions.
message.toBuffer()