Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[statistics-service] fix: geo info unable insert #302

Merged
merged 1 commit into from
Dec 27, 2024
Merged

[statistics-service] fix: geo info unable insert #302

merged 1 commit into from
Dec 27, 2024

Conversation

AnthonyLaw
Copy link
Member

problem: due to the upgraded Mongoose version, the scheme required: true can't accept empty strings, which causes a failed insert to the database.

solution: district and zip value possible to be the empty string, remove required: true in this properties

@AnthonyLaw AnthonyLaw requested a review from Wayonb December 26, 2024 08:32
Wayonb
Wayonb approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@Wayonb Wayonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@AnthonyLaw AnthonyLaw merged commit 07da178 into dev Dec 27, 2024
3 checks passed
@AnthonyLaw AnthonyLaw deleted the fix/geo-location branch December 27, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wayonb Wayonb Wayonb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnthonyLaw @Wayonb