-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tools/shoestring]: light rest implementation #1165
base: dev
Are you sure you want to change the base?
Conversation
da06998
to
4b88efe
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1165 +/- ##
==========================================
- Coverage 98.25% 98.23% -0.02%
==========================================
Files 162 157 -5
Lines 6630 6501 -129
Branches 143 143
==========================================
- Hits 6514 6386 -128
+ Misses 116 115 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
4829dd9
to
535ba7b
Compare
535ba7b
to
202a386
Compare
tools/shoestring/shoestring/templates/docker-compose-light.yaml
Outdated
Show resolved
Hide resolved
a3c3020
to
59aae1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍🏾
have a few questions.
f416269
to
d13e8b9
Compare
tools/shoestring/shoestring/templates/docker-compose-light.yaml
Outdated
Show resolved
Hide resolved
I must understand wrongly, I thought you wanted to keep the |
No, I meant since you added back the
=>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏾
decac18
to
ee91545
Compare
ee91545
to
08690a2
Compare
What was the issue?
What's the fix?
features = API
andlightApi = false
.features = API
andlightApi = true
.full_api
flag in node configuration to define setup full API node.Light rest
is a subset offull API
. I extracted the configuration and applied it to the condition check.