Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* core/core-configuration-layer.el: Fix bug on configuration-layer/describe-package #16804

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

sunlin7
Copy link
Contributor

@sunlin7 sunlin7 commented Jan 25, 2025

Fix a bug when revert the buffer on configuration-layer/describe-package buffer.
Reproduce steps:
0. Start Spacemacs,

  1. Pressing SPC h d P and input a package name to show a help buffer for a package;
  2. Pressing SPC b R to revert the buffer, will trigger an error, like
Debugger entered--Lisp error: (void-function nil)
  nil()
  apply(nil nil)
  help-mode-revert-buffer(t nil)
  revert-buffer(t)
  funcall-interactively(revert-buffer t)
  call-interactively(revert-buffer nil nil)
  command-execute(revert-buffer)

@bcc32 bcc32 self-assigned this Jan 28, 2025
@bcc32 bcc32 self-requested a review January 28, 2025 20:31
@bcc32 bcc32 force-pushed the fix-describe-package branch from 4e6bb80 to bd19d86 Compare January 28, 2025 20:33
@bcc32 bcc32 force-pushed the fix-describe-package branch from bd19d86 to 97b45b1 Compare January 28, 2025 20:33
@bcc32 bcc32 merged commit 97b45b1 into syl20bnr:develop Jan 28, 2025
3 of 4 checks passed
@bcc32
Copy link
Collaborator

bcc32 commented Jan 28, 2025

Nice, thanks. I reworded the commit to be slightly more specific about the bug, but otherwise merged as-is.

@sunlin7
Copy link
Contributor Author

sunlin7 commented Jan 29, 2025

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants