Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Update forge key bindings #11857

Merged
merged 1 commit into from
Jan 17, 2019

Conversation

Miciah
Copy link
Contributor

@Miciah Miciah commented Jan 17, 2019

Update the documentation for forge per upstream changes to key bindings in evil-magit.

  • layers/+source-control/github/README.org: Update key bindings for forge.

Update the documentation for forge per upstream changes to key bindings in
evil-magit[1].

[1] emacs-evil/evil-magit@49978d0

* layers/+source-control/github/README.org: Update key bindings for forge.
@Miciah Miciah force-pushed the github-update-forge-key-bindings branch from b71e25f to ca15848 Compare January 17, 2019 02:45
@sdwolfz sdwolfz added this to the Release 0.300 milestone Jan 17, 2019
@syl20bnr syl20bnr merged commit 01e2db9 into syl20bnr:develop Jan 17, 2019
@syl20bnr
Copy link
Owner

Thank you ! 👍
Cherry-picked into develop branch, you can safely delete your branch.

@yuhan0
Copy link
Contributor

yuhan0 commented Feb 12, 2019

Just a heads up - the upstream changes were reverted in emacs-evil/evil-magit@2915d77 , so these docs are now outdated - "F" no longer opens the forge popup.

A replacement binding hasn't been settled on yet, issue to track is emacs-evil/evil-magit#54 (hope I didn't cause too much bikeshedding there)

@syl20bnr
Copy link
Owner

Thanks for the heads up, reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants