Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include magit/forge SQLite db file in .gitignore #11760

Merged
merged 1 commit into from
Jan 14, 2019
Merged

Include magit/forge SQLite db file in .gitignore #11760

merged 1 commit into from
Jan 14, 2019

Conversation

Asgavar
Copy link
Contributor

@Asgavar Asgavar commented Dec 27, 2018

Where by forge I mean: https://github.com/magit/forge

@Asgavar Asgavar changed the title Include forge SQLite db file in .gitignore Include magit/forge SQLite db file in .gitignore Dec 27, 2018
@nixmaniack
Copy link
Contributor

As of now magit/forge isn't included in spacemacs. Once it's included it'd be better to setup forge-database-file inside ~/.emacs.d/.cache(as per general convention of spacemacs package configs) than add it to .gitignore.

@Miciah
Copy link
Contributor

Miciah commented Dec 28, 2018

I made #11764 (using Forge!) to add Forge to the github layer.

@sdwolfz sdwolfz added this to the Release 0.300 milestone Jan 14, 2019
@sdwolfz sdwolfz merged commit 9f552df into syl20bnr:develop Jan 14, 2019
@sdwolfz
Copy link
Contributor

sdwolfz commented Jan 14, 2019

Thank you ❤️!
And congratulations on your first Spacemacs PR 🎉!
Cherry-picked into develop branch, you can safely delete your branch.

@syl20bnr
Copy link
Owner

As @nixmaniack wrote it is better to put forge-database-file inside ~/.emacs.d/.cache if that's possible and remove the entry from the .gitignore.

@syl20bnr
Copy link
Owner

Ok already done actually. I think this is safe to revert as it should not be necessary.

@syl20bnr
Copy link
Owner

Seems that forge creates the file in .emacs.d when installing...

@Miciah
Copy link
Contributor

Miciah commented Jan 16, 2019

Seems that forge creates the file in .emacs.d when installing...

Do we need to set forge-database-file earlier? Maybe in layers/+source-control/github/config.el?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next Release 0.300
Development

Successfully merging this pull request may close these issues.
5 participants
@Asgavar @nixmaniack @Miciah @sdwolfz @syl20bnr