Start of BinaryWithGravitationalWaves class for XCTS #6428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- class to implement background data - right now it implements superposition of two boosted black holes - no radiative content is added for now Additional BoundaryCondition class to set on inner boundaries: SuperposedBoostedBinary - Dirichlet is implemented - Neumann is not implemented (set to zero) - Neumann will be implemented later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Creation of the class BinaryWithGravitationalWaves for XCTS solver, that computes initial data for binary black hole with realistic wave content.
The conformal data is obtained from a superposition of two boosted objects plus radiative content computed from Post-Newtonian Theory.
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments
The radiative terms are still not computed (set to zero), they will be added in a later PR.
Supersedes past PR #5799.