Refactor agent implementation #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than try to embed a JSON-RPC message inside another JSON-RPC
message (i.e. the `MessageText` notification) this commit changes the
agent to forward the message onto the inspector program (mostly)
unmodified.
The most important detail is that we leave the message encoded as
bytes, this way we don't introduce any errors caused by Python
counting the length of unicode characters differently, depending on if
they are a string or a sequence of bytes.
```python
>>> len('∊')
1
>>> len('∊'.encode())
3
```
As for the metadata fields that were included in the `MessageText`,
these are now passed as additional headers prepended to the captured
message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than try to embed a JSON-RPC message inside another JSON-RPC
message (i.e. the
MessageTextnotification) this commit changes theagent to forward the message onto the inspector program (mostly)
unmodified.
The most important detail is that we leave the message encoded as
bytes, this way we don't introduce any errors caused by Python
counting the length of unicode characters differently, depending on if
they are a string or a sequence of bytes. Closes #157
As for the metadata fields that were included in the
MessageText,these are now passed as additional headers prepended to the captured
message