Merge pull request #4 from swissmanu/develop

fix(map): Allow null as value for Map entry
swissmanu · Apr 18, 2017 · 761433a · 761433a
2 parents 436053c + 357edda
commit 761433a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/parsers/map.ts b/src/parsers/map.ts
@@ -10,11 +10,9 @@ export const fromMap = <T>(map: ParserInput, key: string, valueParser: ParseFn<T
     throw new ParserError('Map', map);
   }
 
-  const value = map[key];
-
-  if (isNil(value)) {
+if (!(key in map)) {
     throw new ParserError(`Map containing key ${key}`, JSON.stringify(map));
   }
 
-  return valueParser(value);
+  return valueParser(map[key]);
 };
diff --git a/test/parsers/map.ts b/test/parsers/map.ts
@@ -1,5 +1,5 @@
 import {expect} from 'chai';
-import {ParserError} from '../../src/parsers';
+import {ParserError, ParseFn} from '../../src/parsers';
 import {fromMap} from '../../src/parsers/map';
 import {aBoolean} from '../../src/parsers/boolean';
 
@@ -32,5 +32,10 @@ describe('Parser', () => {
     it('should throw a ParserError when given a string', () => {
       expect(() => fromMap('test', 'a', aBoolean)).to.throw(ParserError);
     });
+
+    it('should not throw ParserError when given key exists and has value "null"', () => {
+      const aNull: ParseFn<null> = (): null => null;
+      expect(() => fromMap({ a: null }, 'a', aNull)).to.not.throw();
+    })
   });
 });