Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves deserialization efficiency for agents. #741

Merged
merged 13 commits into from
Dec 11, 2024
Merged

Improves deserialization efficiency for agents. #741

merged 13 commits into from
Dec 11, 2024

Conversation

horned-sphere
Copy link
Collaborator

Agent implementations can now keep persistent deserializers for their lanes rather than recreating them each time.

The agents created by the derive macro have been updated to make use of this.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 145 lines in your changes missing coverage. Please review.

Project coverage is 49.23%. Comparing base (c3e09d6) to head (3217459).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
server/swimos_agent/src/lanes/map/mod.rs 27.55% 71 Missing ⚠️
...r/swimos_agent_derive/src/lane_model_derive/mod.rs 0.00% 57 Missing ⚠️
swimos/tests/deriveagentlanemodel.rs 38.46% 8 Missing ⚠️
server/swimos_agent/src/lib.rs 66.66% 3 Missing ⚠️
server/swimos_agent/src/agent_model/mod.rs 60.00% 2 Missing ⚠️
server/swimos_agent/src/event_handler/mod.rs 75.00% 2 Missing ⚠️
server/swimos_connector/src/generic/mod.rs 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #741      +/-   ##
==========================================
- Coverage   49.37%   49.23%   -0.15%     
==========================================
  Files         401      402       +1     
  Lines       35004    35124     +120     
==========================================
+ Hits        17284    17294      +10     
- Misses      17720    17830     +110     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@horned-sphere horned-sphere marked this pull request as ready for review November 27, 2024 16:46
Base automatically changed from flexible-map-dls to main December 11, 2024 10:42
@SirCipher SirCipher merged commit 8a58251 into main Dec 11, 2024
11 checks passed
@SirCipher SirCipher deleted the reuse-deser branch December 11, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants