Adding delete function for Attachment Cursors #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmikov
suggested changes
Nov 4, 2020
| @@ -34,6 +34,24 @@ def add(self, filename, stream, content_type=None): | |||
|
|
|||
| return attachment | |||
|
|
|||
| def delete(self, attachment): | |||
There was a problem hiding this comment.
Since there is not issue linked or jira ticket, can some information be added to the PR about why and example usage?
Will there be unit tests for this functionality?
There was a problem hiding this comment.
This is an important functionality to add.
- The main use case I can think of is if you are syncing records between instances / applications and a parent record attachments have been deleted, you would want it to replicate in the child record(s).
- Another use case could be for record ingestion. For example, if you are ingesting an email which has attachments and a record is created but you still have yet to parse that data, if the record has attachments, but you only want attachments of a particular type, then deleting it when parsing the record would be beneficial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to delete an attachment from an attachment field