-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable more detailed event capture by log handlers #52
Open
thebleucheese
wants to merge
203
commits into
swimlane:main
Choose a base branch
from
thebleucheese:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.1.0 Release
…itch Adding return_atomics switch
0.8.1 Release
0.8.2 Release
0.8.4 Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, we've added some parameters for capturing more detailed logs.
This goes hand in hand with
https://github.com/SecurityRiskAdvisors/py-attire-schema
and
https://github.com/SecurityRiskAdvisors/atomic-operator-attire-logger
the py-attire-schema is published at https://pypi.org/project/py-attire-schema (v1.1.0 to match the current ATTiRe version) since it doesn't depend on these atomic-operator changes. atomic-operator-attire-logger does depend on these first before we can publish.
We added a detailed guide on how we were doing local development on this:
https://github.com/SecurityRiskAdvisors/atomic-operator-attire-logger/wiki/Local-Development
As discussed, we'll look at moving the logger changes into the runner.py file and we'll think a bit on how to separate the output when running on multiple remote hosts since currently it all gets concatenated in the test result output.