tell CTest to print on failure for cmark tests #59978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
Since cmark tests don't run on regular CI, i'm going to also run a specific preset that does run them: preset=buildbot_incremental,tools=RA,stdlib=RDA,test=watchOS,type=simulator |
|
preset=buildbot_incremental,tools=RA,stdlib=RDA,test=watchOS,type=simulator |
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test |
edymtt
approved these changes
Jul 11, 2022
| @@ -117,7 +117,9 @@ def target_flag(target): | |||
| if test_target.startswith("check-swift") and self.args.test_paths: | |||
| test_target = test_target + "-custom" | |||
|
|
|||
| shell.call(cmake_build + target_flag(test_target)) | |||
| # note that passing variables via test_env won't affect lit tests - | |||
There was a problem hiding this comment.
I like how readable this comment is.
| "CTEST_OUTPUT_ON_FAILURE": "ON" | ||
| } | ||
|
|
||
| # see the comment in cmake_product.py if you want to copy this code to pass |
There was a problem hiding this comment.
Good idea to add a breadcrumb here while keeping the main message in a single place.
hborla
pushed a commit
to hborla/swift
that referenced
this pull request
Jul 21, 2022
Catfish-Man
pushed a commit
to Catfish-Man/swift
that referenced
this pull request
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that rdar://96543740 can be more easily investigated, this PR updates the build system to print the test log if a cmark test fails, to make the CI console display what went wrong.