Support building swift-format using SwiftPM for toolchain builds on Windows #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
windows-build
branch
2 times, most recently
from
b53c33a to
8612c6a
Compare
…indows This allows us to also run tests of swift-format on Windows.
ahoppen
commented
Oct 7, 2024
Comment on lines
+89
to
+91
| var first = first | ||
| first.leadingTrivia = trimmedLeadingTrivia | ||
| result[index] = first |
There was a problem hiding this comment.
I haven’t had a chance to reduce the failure but I think test execution crashes with the previous code due to swiftlang/swift#67676.
There was a problem hiding this comment.
This is fine anyway, I've come to mildly disfavor the bespoke with methods and just use normal value type mutation for operations like this.
allevato
approved these changes
Oct 8, 2024
Comment on lines
+89
to
+91
| var first = first | ||
| first.leadingTrivia = trimmedLeadingTrivia | ||
| result[index] = first |
There was a problem hiding this comment.
This is fine anyway, I've come to mildly disfavor the bespoke with methods and just use normal value type mutation for operations like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to also run tests of swift-format on Windows.