Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the Calendar View of all the events #96

Open
wants to merge 8 commits into
base: staging
Choose a base branch
from

Conversation

daynamariejpembie
Copy link
Contributor

I have added the Calendar view of the tech alliance events. This is for issue #52
Below are screenshots of what I achieved, any feedback is much appreciated:
image
image

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tech-alliance-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 7:21pm

Copy link
Member

@zarela zarela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the calendar button opens also the rest of the original home page.

</iframe>
</div>
)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This little icon means you need to add an empty line at the end of everything

return (
<div>
<Navigation />
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to add a div here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, we could remove this

Copy link
Member

@zarela zarela Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't include changes in this file, unless we added something to the package.json

return (
<div>
<Navigation />
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, we could remove this

@@ -36,7 +43,14 @@ function classNames(...classes) {
}

export default function Navigation() {
const [showCalendar, setShowCalendar] = useState(false);

const handleCalendarClick = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daynamariejpembie sorry if I wasn't explicit on this.

But basically we only need here is a new Page with the calendar, where the users could go back and forward from it.

Lets create a new Page and call it Calendar, add the Iframe there, then we should be good to go there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonathans199 I'm taking a look at this to help @daynamariejpembie. To be clear, what you're talking about doing is making a calendar.js page under the pages directory right? And that would just contain the iframe. Then there needs to be ternary (or some other way of bringing the calendar to view) inside components/Header/Navigation.jsx that disables the mobile or medium and up sized buttons and then renders the calendar? The second part is tripping me up in particular, and that may not be how it needs to rendered. Please elaborate so we can implement this, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants