fix: sympy log parser fails to recognize the last test case #212
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Add additional checking and cleaning steps to the sympy log parser.
Previously, the sympy log parser could not parse the last line of the log file. For example, the following log (where
test_intersection_of_duplicate_sets
is a test I added manually):The current log parser will ignore the last line because there is a text
[FAIL]
(or[OK]
) at the end of that line. This text will appear in the log when all the test functions in the file have been executed. This logic is inleaving_filename
function, which will be called at the end of thetest_file
function.To fix this, we can simply check to see if there is a
[FAIL]
or[OK]
at the end of the line, and if there is, we can simply delete it andstrip
theline
again.