Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tabs to student dashboard #289

Open
wants to merge 7 commits into
base: qosi
Choose a base branch
from

Conversation

Aviral09
Copy link
Member

Added Services, CSA, SAC and Contact Us tabs to student dashboard. After navigating to one of these pages, the student can return to the student dashboard after clicking on 'Home' on any of these pages. This solves issue number #243
File changed:
base.html

hello

Added Services, CSA, SAC and contact us tabs to student dashboard. The student can return to the student dashboard after clicking on home on any of these pages.
Comment on lines 47 to 52
<li><a href="/swd">Services</a></li>
<li><a href="/csa">CSA</a></li>
<li><a href="/sac">SAC</a></li>
<li><a href="/contact">Contact Us</a></li>
<li class=""><a href="/profile" class="valign-wrapper"><img class="circle profileImg" src="/media/{{ student.profile_picture }}">&nbsp;{{ student.name|title }}</a></li>
<li><a href="/logout">Logout</a></li>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, It would be better if you would replace these hardcoded urls with django template url tag.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The urls have been hardcoded in the entire document. Shall I replace all the urls in base.html with template url tags?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that should be better.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@aryanagarwal15
Copy link
Collaborator

@Aviral09 can you show how it looks on Mobile?

When I designed it the problem was not for desktop but for showing links on Mobile. We also don't want different features available on mobile and desktop. So untill the pages are available on Mobile it doesn't make sense to add them to desktop

@Aviral09
Copy link
Member Author

@Aviral09 can you show how it looks on Mobile?

When I designed it the problem was not for desktop but for showing links on Mobile. We also don't want different features available on mobile and desktop. So untill the pages are available on Mobile it doesn't make sense to add them to desktop

Updated mobile view
hi

@aryanagarwal15
Copy link
Collaborator

This won't do bro, we need to figure out a better UI. Let me talk to the designers for this. Till then @khizirsiddiqui let this be open only.

@Aviral09
Copy link
Member Author

Has any progress been made regarding UI design?

@aryanagarwal15
Copy link
Collaborator

It will take some time, since all UI designers are busy. Expect this to be resolved by second week of August.

@Aviral09
Copy link
Member Author

Okay noted. Thankyou! I will start working on some other issue.

@aryanagarwal15
Copy link
Collaborator

Screenshot 2020-08-23 at 10 11 49 PM

Screenshot 2020-08-23 at 10 12 51 PM

Hey @Aviral09 this is the design for looged in mobile

@Aviral09
Copy link
Member Author

Aviral09 commented Sep 9, 2020

Sorry I checked in late. Will update it accordingly soon.

@Aviral09
Copy link
Member Author

Changes have been made according to the designs. Sorry for the delay!
image

@aryanagarwal15
Copy link
Collaborator

@Aviral09 please share screenshots of both mobile and desktop for login and logout state

@aryanagarwal15
Copy link
Collaborator

This is not following design. Please make changes in css and share screenshot with commit

@Aviral09
Copy link
Member Author

Updated Design

Desktop Logged in
Desktop_login

Desktop logged out
Desktop_logout

Mobile logged in
Mobile_login

Mobile logged out
Mobile_logout

@aryanagarwal15
Copy link
Collaborator

Hey @Aviral09 nice work till now, still I beleive the designs are not properly followed.

Pointers:

  1. Mobile Logged out view needs to be changed according with logged in view (designs are available above)
  2. Desktop Logged in view also need to have all the links (will share those designs soon)
  3. if you see in one of the designs it is mentioned how color changes are to be implemented for focused tab.

Please also make sure that you are using all the colors in the design if you face any difficulties in finding out design colors then comment here for help.

@Aviral09
Copy link
Member Author

Aviral09 commented Sep 26, 2020

@aryanagarwal15
Okay, my bad I didn't see the focussed tab part and assumed them to just be hoverable. Will implement the focussed part accordingly.
I need some other clarifications to implement the design as well.

Right now the implementation is as follows-
My account and About Us are collapsible which expand on click.
All the tabs are hoverable and on hover, colour changes to orange. For My Account and About Us, the collapsible headers are orange in case any of the child tabs is hovered or focussed on.

Clarifications needed:

  1. Were About Us and My Account not supposed to be collapsible?
  2. What will be the functionality of My Account in the Not logged-in state?
  3. Where should I put Migration, Contact Us etc in Desktop logged in view? Will my very first design be fine for it?
  4. Your designs don't mention daypass tab. Am I supposed to remove it?
  5. Your designs mention an Events tab but no such template exists.

Thank you in advance! Also, if it is possible, can we communicate on slack to avoid future misunderstandings?

@aryanagarwal15
Copy link
Collaborator

  1. They are not supposed to be collapsable. Need to be viewable at all times
  2. Should take user to login window
  3. I'll share the design for desktop as well
  4. That functionality is added later. Please make sure all the tabs which are present right now is present in future as well
  5. Same as point 2

You can ping me at [email protected] if you need any immediate help.

@aryanagarwal15
Copy link
Collaborator

For point 3 your approach work as well. I think we can stick to that

@Aviral09
Copy link
Member Author

Apologies for the delay! This semester has been a bouncy ride😅
I have updated everything according to the designs. Also included the submit mcn button.
While the navbars have been updated, a small issue is that when tried accessing CSA, SWD or Contact Us pages, since they extend indexbase, the user gets logged out. (To be more precise the logged out nav bar comes up).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants