-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tabs to student dashboard #289
base: qosi
Are you sure you want to change the base?
Conversation
Added Services, CSA, SAC and contact us tabs to student dashboard. The student can return to the student dashboard after clicking on home on any of these pages.
swd/templates/base.html
Outdated
<li><a href="/swd">Services</a></li> | ||
<li><a href="/csa">CSA</a></li> | ||
<li><a href="/sac">SAC</a></li> | ||
<li><a href="/contact">Contact Us</a></li> | ||
<li class=""><a href="/profile" class="valign-wrapper"><img class="circle profileImg" src="/media/{{ student.profile_picture }}"> {{ student.name|title }}</a></li> | ||
<li><a href="/logout">Logout</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, It would be better if you would replace these hardcoded urls with django template url tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The urls have been hardcoded in the entire document. Shall I replace all the urls in base.html with template url tags?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that should be better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
@Aviral09 can you show how it looks on Mobile? When I designed it the problem was not for desktop but for showing links on Mobile. We also don't want different features available on mobile and desktop. So untill the pages are available on Mobile it doesn't make sense to add them to desktop |
|
This won't do bro, we need to figure out a better UI. Let me talk to the designers for this. Till then @khizirsiddiqui let this be open only. |
Has any progress been made regarding UI design? |
It will take some time, since all UI designers are busy. Expect this to be resolved by second week of August. |
Okay noted. Thankyou! I will start working on some other issue. |
Hey @Aviral09 this is the design for looged in mobile |
Sorry I checked in late. Will update it accordingly soon. |
@Aviral09 please share screenshots of both mobile and desktop for login and logout state |
This is not following design. Please make changes in css and share screenshot with commit |
Hey @Aviral09 nice work till now, still I beleive the designs are not properly followed. Pointers:
Please also make sure that you are using all the colors in the design if you face any difficulties in finding out design colors then comment here for help. |
@aryanagarwal15 Right now the implementation is as follows- Clarifications needed:
Thank you in advance! Also, if it is possible, can we communicate on slack to avoid future misunderstandings? |
You can ping me at [email protected] if you need any immediate help. |
For point 3 your approach work as well. I think we can stick to that |
Apologies for the delay! This semester has been a bouncy ride😅 |
Added Services, CSA, SAC and Contact Us tabs to student dashboard. After navigating to one of these pages, the student can return to the student dashboard after clicking on 'Home' on any of these pages. This solves issue number #243
File changed:
base.html