Update python-novice-inflammation (and split PO files) #146
+35,832
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is right file structure we want for split PO files, but I'm giving it a try. We can either build off what I've done here, or scrap this PR and try a different approach.
I followed the instructions on the Carpentries i18n repo.
Those instructions are more geared towards transifex. We aren't using transifex, but I still think the idea of splitting PO files will make them easier to edit.
splitpot.pycreates atransifexdirectory and puts the split POT files in there (within a sub-directory for the lesson, heretransifex/python-novice-inflammation). It doesn't automatically create PO files. I added another directory for the PO files (transifex/python-novice-inflammation/po) and copied them over from the POT files intransifex/python-novice-inflammation/pot.