-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to update texts #230
base: master
Are you sure you want to change the base?
Conversation
What's the use-case for this? |
Just if you want to change the swaylock basic texts. In my case, I don't like the texts without maj : "clear", "wrong". And now, you can have "Clear", "Wrong", or others "key-words" as "Error", or every words. |
This doesn't strike me as a very useful feature. |
I know that some persons (including me) don't like basic texts, especially without first capital letter. That may be used for others languages too. |
I'd be open to capitalize the text FWIW. The lowercase versions aren't a deliberate decision IIRC. Or maybe it's to mimic i3lock? What does i3lock do here? For translations, I think something like #151 would be a better approach. |
Capitalize, FWIW: https://github.com/i3/i3lock/blob/4f76d51a3f79082e01b319e9031aad868d89449d/unlock_indicator.c#L218 |
I think this would be a useful feature for further customization. Is there any chance of this being merged anytime soon in the future? |
It would be great for other languages. Is there any other way to change English ? |
Would also really appreciate this as I'd like to show the battery percentage on the lock screen so I can check it when my laptop is charging without having to unlock it every time. |
This pull request allows users to update all the texts, when password is cleared, when caps lock is active, when password is verified and when password is wrong.