Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #150 #151

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Fix #150 #151

merged 2 commits into from
Oct 21, 2024

Conversation

kddubey
Copy link
Contributor

@kddubey kddubey commented Oct 11, 2024

Fix #150

Python 3.13 changed the way arguments with shorter aliases are presented in the help message. tests/test_to_tap_class.py tests for exact string match of the help message, so the test needs to be updated.

How has this been tested?

Ran pytest in an environment with Python 3.13 installed and then in an environment with Python 3.11 installed.

Also added Python 3.13 to the testing workflow

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.70%. Comparing base (1a3af2a) to head (00dcff8).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   94.70%   94.70%           
=======================================
  Files           4        4           
  Lines         718      718           
=======================================
  Hits          680      680           
  Misses         38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddubey
Copy link
Contributor Author

kddubey commented Oct 11, 2024

Should also prolly update the Python version badge in the README to include 3.13. Or can use the shorter python 3.8+ badge here: https://img.shields.io/badge/python-3.8+-blue.svg

Will leave that up to you

@swansonk14
Copy link
Owner

Hi @kddubey,

Thank you so much for fixing this!! We really appreciate it! I'll merge in your PR and then make one additional change to actually remove support for Python 3.8 since it just reached end-of-life (https://devguide.python.org/versions/).

Best,
JK

@swansonk14 swansonk14 merged commit 69d2f0a into swansonk14:main Oct 21, 2024
20 checks passed
@kddubey kddubey deleted the to-tap-class-fix-py313 branch October 21, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail on Python 3.13
3 participants