Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat openapiv3 oneof #1870

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Feat openapiv3 oneof #1870

merged 3 commits into from
Oct 21, 2024

Conversation

KKKIIO
Copy link
Contributor

@KKKIIO KKKIIO commented Aug 13, 2024

Describe the PR
Adds support for the oneOf feature in OpenAPI v3, allowing you to describe a field/response that can have multiple types.

Relation issue
#1363
#1617

Additional context
Unfortunately, the PR #1671 was reverted due to a compile error caused by the use of the maps package.
The maps package was introduced in Go 1.21, but the project is currently using Go 1.18.

@ubogdan
Copy link
Contributor

ubogdan commented Oct 20, 2024

Please rebase from V2, we updated the go version and it's very likely to work now.

@ubogdan ubogdan added the v2 Used for all v2 related issues label Oct 20, 2024
@KKKIIO KKKIIO closed this Oct 21, 2024
@KKKIIO KKKIIO force-pushed the feat-openapiv3-oneof branch from 6cc8177 to 2fa63cf Compare October 21, 2024 14:28
@KKKIIO KKKIIO reopened this Oct 21, 2024
Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan ubogdan merged commit 6700370 into swaggo:v2 Oct 21, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2 Used for all v2 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants