Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete payments when Payment.NONE in pizzas #1035

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Conversation

se-bastiaan
Copy link
Contributor

@se-bastiaan se-bastiaan commented Mar 18, 2020

Partial implementation of #957 and #1002

Short description

Removes Payment.NONE usage in pizzas and uses create_payment + delete_payment.

@se-bastiaan se-bastiaan changed the title Issue #961 Delete payments when Payment.NONE in pizzas Delete payments when Payment.NONE in pizzas Mar 18, 2020
@se-bastiaan se-bastiaan added app:payments Issues regarding the payments-app chore Something that is not a bug or a feature, does not change production behaviour wip labels Mar 18, 2020
@github-actions github-actions bot added the app:pizzas Issues regarding the pizzas-app label Mar 19, 2020
@github-actions github-actions bot added the app:events Issues regarding the events-app label Mar 19, 2020
@se-bastiaan se-bastiaan marked this pull request as ready for review March 19, 2020 20:54
@se-bastiaan se-bastiaan removed the wip label Mar 19, 2020
website/pizzas/models.py Outdated Show resolved Hide resolved
website/pizzas/services.py Outdated Show resolved Hide resolved
@se-bastiaan se-bastiaan force-pushed the pizza-payment-none branch 3 times, most recently from 79d5964 to d4c5e76 Compare March 21, 2020 22:58
website/pizzas/models.py Outdated Show resolved Hide resolved
website/events/services.py Show resolved Hide resolved
@se-bastiaan se-bastiaan merged commit 6837ba2 into master Mar 25, 2020
@se-bastiaan se-bastiaan deleted the pizza-payment-none branch March 25, 2020 22:01
@se-bastiaan se-bastiaan added this to the 32 milestone Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:events Issues regarding the events-app app:payments Issues regarding the payments-app app:pizzas Issues regarding the pizzas-app chore Something that is not a bug or a feature, does not change production behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants