Add MyDealz sanitizer as per #358 #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmbreuer
force-pushed
the
pr-mydealz
branch
2 times, most recently
from
ac14a08
to
34f0be4
Compare
|
... "stupid" question - can I easily run the lint checks locally? (I'm using Android Studio - it's supposed to have some support, but it looks like it's "different" from what the build checks do...) |
jmbreuer
force-pushed
the
pr-mydealz
branch
4 times, most recently
from
dfb020d
to
2a27cbd
Compare
The build checks perform code style analysis. |
svenjacobs
requested changes
Oct 25, 2024
...n/kotlin/com/svenjacobs/app/leon/core/domain/sanitizer/mydealz/MyDealzParametersSanitizer.kt
Outdated
Show resolved
Hide resolved
svenjacobs
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick implementation for #358
Tested with URLs from that issue, otherwise implemented fairly 'blind' - i.e. I don't have the MyDealz app, and I won't let it anywhere near an actual device that I could use for testing - sorry, not sorry 😉
Resolves #358