-
Notifications
You must be signed in to change notification settings - Fork 58
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Requiring ostruct on Ruby 3.4 warns: ``` /home/user/.rbenv/versions/3.4.1/lib/ruby/gems/3.4.0/gems/gem-release-2.2.2/lib/gem/release/data.rb:2: warning: /home/user/.rbenv/versions/3.4.1/lib/ruby/3.4.0/ostruct.rb was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. You can add ostruct to your Gemfile or gemspec to silence this warning. Also please contact the author of gem-release-2.2.2 to request adding ostruct into its gemspec. ``` But since the values that this ostruct will take is known, there is no need to use ostruct all all. I've simply replaced it with a normal struct. It's a bit akward because of support for such old ruby versions (no `keyword_init`) but works out.
- Loading branch information
Showing
3 changed files
with
18 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,7 +59,7 @@ def binding | |
end | ||
|
||
def context | ||
Context.new(data) | ||
Context.new(*data.values) | ||
end | ||
end | ||
end | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters