Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chinese holidays #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

MenoData
Copy link

see #43

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 83.064% when pulling 570661e on MenoData:master into e359ee2 on svendiedrichsen:master.

@svendiedrichsen
Copy link
Owner

Great work. Glad to include it. Just one minor request. Please see review.

@MenoData
Copy link
Author

Hm, I have problems to see any review or minor request. Anyway, this PR will ensure to find the right days of official chinese holidays and those of Hongkong. What is not yet tackled are the complex compensation rules when ever a holiday falls on a weekend (see wikpedia), but this might be realized in another second step (you know better your API). And sometimes the government of China can suddenly change the compensation rules as happened several times in the past, so ultimate safety for any holiday dates is only given by official announcements in December.

@maccamlcQ
Copy link
Contributor

I had a quick look at this PR, and trying to understand how the Chinese holidays are arranged. Would the intention for Chinese New Year, for example, be to list holiday as only the actual day, or try to find a way to cover the 7 day holiday from Eve to 6 days later?

I assume would need some additional constructs to calculate this type of requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants