-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs]: Add transitions on expanding in Sidebar #388
Conversation
I've been away from the computer this week, I will take a look at this tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice one problem with this change: when navigating to another page, the sidebar animates when opened, which creates a weird effect:
transition_sidebar.mp4
Perhaps it's best to remove the transitions in the sidebar sections for now.
Yeah, for some reason, even though there is no change to the |
Hum, did you try adding the |
Yeah, that works! |
I've added the latest commit in my fork but there seems to be some issue with merging. Could you take a look at it? |
Nvm, it's fixed. I'll take a look at the conflicts |
Sorry, been busy, I'll pick it up today or tomorrow |
Sorry again, I'll pick it up tomorrow for sure! |
Thank you for this contribution! 🙌 And so sorry for the delay, life got a bit hectic for a while, now back to normal. |
Description
Title
Before submitting the PR, please make sure you do the following
[@svelteui/core]
,[@svelteui/actions]
,[@svelteui/motion]
,[@svelteui/core]
,[core]
, or[docs]
.yarn lint
andyarn test
or just runyarn prepush
.