-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ignore *.{test,spec}.{js,ts}
and similar files
#13009
base: main
Are you sure you want to change the base?
Conversation
6c43108
to
6e0f0eb
Compare
🦋 Changeset detectedLatest commit: d4298f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🦋 Changeset detectedLatest commit: 6e0f0eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
preview: https://svelte-dev-git-preview-kit-13009-svelte.vercel.app/ this is an automated message |
*.{test,spec}.{js,ts}
and similar files
I don't think we need extra config for this - which could also be abused to hide files from the router which it should otherwise not (like a backdoor to customize your routing scheme in weird ways). |
I don't agree with that. First, because you may have different/multiple extensions, or a combination. It's not rare to see:
Also, I don't think something shouldn't be added just because there is a chance it can be misused. |
6e0f0eb
to
b5d60b8
Compare
a1c4974
to
d4298f8
Compare
Closes #13008, please see issue for more details
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits