Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignore *.{test,spec}.{js,ts} and similar files #13009

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rChaoz
Copy link
Contributor

@rChaoz rChaoz commented Nov 15, 2024

Closes #13008, please see issue for more details


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@rChaoz rChaoz force-pushed the feat/test-extensions branch from 6c43108 to 6e0f0eb Compare November 15, 2024 16:55
Copy link

changeset-bot bot commented Nov 15, 2024

🦋 Changeset detected

Latest commit: d4298f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

changeset-bot bot commented Nov 15, 2024

🦋 Changeset detected

Latest commit: 6e0f0eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-13009-svelte.vercel.app/

this is an automated message

@rChaoz rChaoz changed the title Ignore +server.test.ts and similar files feat: ignore \*.{test,spec}.{js,ts} and similar files Nov 15, 2024
@rChaoz rChaoz changed the title feat: ignore \*.{test,spec}.{js,ts} and similar files feat: ignore *.{test,spec}.{js,ts} and similar files Nov 15, 2024
@eltigerchino eltigerchino added the feature / enhancement New feature or request label Nov 18, 2024
@dummdidumm
Copy link
Member

I don't think we need extra config for this - which could also be abused to hide files from the router which it should otherwise not (like a backdoor to customize your routing scheme in weird ways). .test/.spec.{js.ts} will suffice

@rChaoz
Copy link
Contributor Author

rChaoz commented Jan 23, 2025

I don't agree with that. First, because you may have different/multiple extensions, or a combination. It's not rare to see:

  • x.test.svelte.js / x.svelte.test.js
  • other extensions like .stories, for example used with +page.stories.svelte
  • separation between unit/int tests, for example x.test.js and x.int.test.js

Also, I don't think something shouldn't be added just because there is a chance it can be misused.

@rChaoz rChaoz force-pushed the feat/test-extensions branch from 6e0f0eb to b5d60b8 Compare January 23, 2025 19:53
@rChaoz rChaoz force-pushed the feat/test-extensions branch from a1c4974 to d4298f8 Compare January 25, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature / enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore +server.test.ts and similar files
4 participants