add normal test for CI #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be the last thing before transitioning to the OO version |
|
I'm still trying to wrap my mind around using GitHub Actions for CI. What's the purpose of having tests triggered by both pull requests and commit pushes? And something I'm still slightly unclear about is which version of the code is being tested for each GitHub Action workflow. |
|
The other test only runs when a push happens and one of those two specific files changes: the GH action itself or the Dockerfile. This test only runs on a pull request when any file changes. We could, technically, NOT run this test when those two files change. |
connoramoreno
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.