add option to export to cub5 #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see I am not passing CI tests I'll try to get to the bottom of it |
gonuke
requested changes
Jun 1, 2024
| @@ -63,6 +63,7 @@ invessel_build: | |||
| mat_tag: vac_vessel | |||
| plasma_mat_tag: Vacuum | |||
| sol_mat_tag: Vacuum | |||
| split_chamber: True | |||
There was a problem hiding this comment.
Is this a necessary part of this PR? or just left over from your testing?
|
I'll try from a branch on the upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added an option to export to cub5 as an optional arg for the
stellarator.export_dagmc()method. Added a test for this method as well, not sure if it is necessary or not since this is sort of an internal cubit thing and if the DAGMC file gets generated I would expect that the .cub5 file will also be written, though I suppose this test would catch if coreform ever changes that syntax on us.Also added a small change to config.yaml to allow it to work from the command line, I tested both from the command line and from the python interface and things seem to work as expected. Tests are passing locally as well.
closes #93
works with yaml, and has the same filename as specified for the DAGMC file