Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several WT script editor tweaks #7892

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Several WT script editor tweaks #7892

merged 2 commits into from
Dec 2, 2024

Conversation

mkruselj
Copy link
Collaborator

@mkruselj mkruselj commented Dec 2, 2024

Trim trailing whitespace on script apply (also in Formula editor)
No vertical axis, grid, nor frame gap in filmstrip
More visible frame number in filmstrip (also aligned top right)
Checkerboard background of odd frames in filmstrip
Add frame number to single view (aligned top right)
Add menu entry to open WT script editor when right-clicking the oscillator display

Addresses one item in #4539

Trim trailing whitespace on script apply (also in Formula editor)
No vertical axis, grid, nor frame gap in filmstrip
More visible frame number in filmstrip (also aligned top right)
Checkerboard background of odd frames in filmstrip
Add frame number to single view (aligned top right)
Add menu entry to open WT script editor when right-clicking the oscillator display
@baconpaul
Copy link
Collaborator

Oh irritating. I added that me u item yesterday but it seems @blancoberg removed it in ab8acad and that merge also removed some of my other lua changes to the stack debugger

did I merge that without review? I’m sorry if so we should not have merged the changes to the files other than the editor

@blancoberg
Copy link
Contributor

Oh irritating. I added that me u item yesterday but it seems @blancoberg removed it in ab8acad and that merge also removed some of my other lua changes to the stack debugger

did I merge that without review? I’m sorry if so we should not have merged the changes to the files other than the editor

Oh, sorry about that Paul. I have no idea how that happened other than I suck at git

@baconpaul
Copy link
Collaborator

It’s no problem I can put it back.

justnits kinda funny that evil merged the change to remove it that menu item then coded the change to add that menu item. That’s how i noticed. But that pop matters so I need to put it back

If wavetable name exists (is not "(Patch Sample)" or "(Patch Wavetable)",
it will be exported to WAV using that name

Also, make the menu entry to rename the wavetable consistent with other rename actions.
@mkruselj mkruselj merged commit dca86f3 into main Dec 2, 2024
14 checks passed
@mkruselj mkruselj deleted the wtse-tweaks branch December 2, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants