Simplify process_block_until_close() #7864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n 2 steps and as in all cases NDX was 1, analysers warned that the loop part was ineffective. To eliminate this warning, and simplify the code, just do a single loop from zero and also exit the loop when it fails the first test (should there ever be a use with NDX > 1). Also simplify to only have the single call to processSmoothing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In process_block_until_close(), the equality checking was performed in 2 steps and as in all cases NDX was 1, analysers warned that the loop part was ineffective.
To eliminate this warning, and simplify the code, just do a single loop from zero and also exit the loop when it fails the first test (should there ever be a use with NDX > 1).
Also simplify to only have the single call to processSmoothing.